1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/ssh/ssh-arch.c ssh-co

    From Deuc¿@VERT to Git commit to main/sbbs/m on Friday, March 27, 2026 07:18:00
    https://gitlab.synchro.net/main/sbbs/-/commit/6e4e9d9919a68790ea4a0bb4
    Modified Files:
    src/ssh/ssh-arch.c ssh-conn.c ssh-trans.c
    Log Message:
    Remove branch coverage wallpaper

    Claude was supposed to put these guards in where the test was actually invariant. The ssh-arch.c one was like that, but pretty much all of
    the others were just current code behaviour, not invariants.

    In short, Claude can't be trusted to do this work, it sees it as
    a handy back-door way to get 100% branch coverage without writing
    tests, which makes it worthless.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From MRO@VERT/BBSESINF to Deuc¿ on Friday, March 27, 2026 11:10:00
    Re: src/ssh/ssh-arch.c ssh-conn.c ssh-trans.c
    By: Deuc¨ to Git commit to main/sbbs/master on Fri Mar 27 2026 07:18 am

    https://gitlab.synchro.net/main/sbbs/-/commit/6e4e9d9919a68790ea4a0bb4 Modified Files:
    src/ssh/ssh-arch.c ssh-conn.c ssh-trans.c
    Log Message:
    Remove branch coverage wallpaper

    Claude was supposed to put these guards in where the test was actually invariant. The ssh-arch.c one was like that, but pretty much all of
    the others were just current code behaviour, not invariants.

    In short, Claude can't be trusted to do this work, it sees it as
    a handy back-door way to get 100% branch coverage without writing
    tests, which makes it worthless.

    Claude has been not great lately.

    --
    "Before using Wildcat....This Company did not have a convenient way of
    looking after some of the richest clients in the world...Now we do!"


    President of BBS Sysop's Union +++ https://bbses.info/union
    ---
    þ Synchronet þ ::: BBSES.info - free BBS services :::
  • From Deuc¿@VERT to Git commit to main/sbbs/m on Friday, March 27, 2026 20:57:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ef7aa088602f6496b7d3c37c
    Modified Files:
    src/ssh/ssh-arch.c ssh-conn.c src/ssh/test/dssh_test_alloc.c dssh_test_alloc.h test_arch.c test_conn.c
    Log Message:
    Add alloc failure sweeps for channel open, conditional demux exclusion

    Two new alloc sweep tests (open_exec, open_shell) iterate malloc failure
    points during channel open, verifying NULL return without crash or hang.

    New dssh_test_alloc_exclude_new_threads() flag lets tests opt demux
    threads out of alloc injection. The flag is conditional -- demux only self-excludes when the test explicitly sets it, so future server-side
    demux alloc tests remain possible. Cleared by dssh_test_alloc_reset().

    Reorder ssh-arch.c NULL guards (val/pos first, buf last) and add
    explicit NULL tests for dssh_parse_uint32 and dssh_serialize_uint32
    to reach 100% branch coverage on ssh-arch.c.

    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net